Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve description for rot in <facing> IDF element #7383

Closed
Anders-Markvardsen opened this issue Feb 6, 2013 · 1 comment
Closed

Improve description for rot in <facing> IDF element #7383

Anders-Markvardsen opened this issue Feb 6, 2013 · 1 comment
Assignees
@Anders-Markvardsen
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 2.5

Comments

@Anders-Markvardsen
Copy link
Member

The IDF <facing> have an optional attribute rot. However, I am
at 90% certain that it serves no additional purpose, i.e. that
the following pieces of xml is identical:

<location rot="45">``<facing x="0" y="0" z="0"/>``</location>

and

<location>``<facing rot="45" x="0" y="0" z="0"/>``</location>

From a quick search GEM appeared to be the only instrument using
this facing rot attribute.

Purpose of this ticket is to clean this up
@Anders-Markvardsen
Copy link
Member Author

This issue was originally trac ticket 6537

@Anders-Markvardsen Anders-Markvardsen added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Mantid labels Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen self-assigned this Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen added this to the Release 2.5 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anders-Markvardsen Anders-Markvardsen

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 2.5
Development

No branches or pull requests
1 participant
@Anders-Markvardsen