Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANS: SetDetectorOffsets #7431

Closed
Anders-Markvardsen opened this issue Feb 18, 2013 · 2 comments
Closed

SANS: SetDetectorOffsets #7431

Anders-Markvardsen opened this issue Feb 18, 2013 · 2 comments
Assignees
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@Anders-Markvardsen
Copy link
Member

SetDetectorOffsets does not appear to be working properly

Hi Anders,

So below is what you sent me before Christmas. Attached is the Python routine I showed you this morning.

As you can see I’ve commented out the two lines re-loading the data file and calling MoveInstrumentComponent. But the output seems to show that no offsets have been applied to the detector positions.

So either SetDetectorOffsets is not doing what it should, or some way of ‘forcing’ the application of the offset specified by SetDetectorOffsets is necessary?

Thanks,
Steve

From: Markvardsen, Anders (STFC,RAL,ISIS)
Sent: 18 December 2012 12:39
To: King, Stephen (STFC,RAL,ISIS)
Subject: RE: det position corrections

Hi Steve,

The python method in ISISCommandInterface.py which exposes this is

def SetDetectorOffsets(bank, x, y, z, rot, radius, side):
"""
Adjust detector position away from position defined in IDF. On SANS2D the detector
banks can be moved around. This method allows fine adjustments of detector bank position
in the same way as the DET/CORR userfile command works. Hence please see
http://www.mantidproject.org/SANS_User_File_Commands#DET for details.

    Note, for now, this command will only have an effect on runs loaded 
    after this command have been executed (because it is when runs are loaded 
    that components are moved away from the positions set in the IDF)

    @param bank: Must be either 'front' or 'rear' (not case sensitive)       
    @param x: shift in mm
    @param y: shift in mm
    @param z: shift in mm
    @param rot: shift in degrees
    @param radius: shift in mm
    @param side: shift in mm

Hope this helps,
Anders

From: King, Stephen (STFC,RAL,ISIS)
Sent: 18 December 2012 12:03
To: Markvardsen, Anders (STFC,RAL,ISIS)
Subject: det position corrections

Hi Anders,

What Python algorithm do I need to call from a script to apply

DET/CORR FRONT RADIUS 48.0
DET/CORR FRONT SIDE 0.0

corrections to SANS2D data I’ve just read in.

For the other offset corrections like

DET/CORR FRONT Z 47.0

MoveInstrumentComponent did the trick but that seems to be specific to X, Y & Z...

Thanks,
Steve

@Anders-Markvardsen
Copy link
Member Author

This issue was originally trac ticket 6585

@Anders-Markvardsen
Copy link
Member Author

@Anders-Markvardsen Anders-Markvardsen added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Mantid labels Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen self-assigned this Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen added this to the Release 2.5 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant