Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ISIS indirect reduction into Mantid and write proper system tests for it #7513

Closed
abuts opened this issue Mar 5, 2013 · 1 comment
Closed
Assignees
Labels
Direct Inelastic Issues and pull requests related to direct inelastic
Milestone

Comments

@abuts
Copy link
Member

abuts commented Mar 5, 2013

Mantid currently uses DirectInelastic reduction algorithms which is used for converting data to energy transfer. The integrity of these is verified by the system tests.

These algorithms are the basis for customized reduction, actually used in ISIS excitation group to process the experimental results.

The custom algorithms mainly rely on Mantid algorithm but override different settings from different places and have some parts of the algorithm implemented differently.

  1. The custom algorithm are not covered by system tests and can be easily broken by the changes in Mantid core

  2. Two (actually three) sets of default parameters plus possibility to set up parameters from the script itself make it difficult to understand what parameter is actually used.

The purpose of this ticket is to bring all ISIS inelastic reduction script into Mantid and verify its integrity by proper system tests.

Isis reduction script should be very thin layer over verified Mantid reduction scripts.

@abuts
Copy link
Member Author

abuts commented Jun 3, 2015

This issue was originally trac ticket 6667

@abuts abuts added the Direct Inelastic Issues and pull requests related to direct inelastic label Jun 3, 2015
@abuts abuts self-assigned this Jun 3, 2015
@abuts abuts added this to the Release 2.6 milestone Jun 3, 2015
@abuts abuts closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Direct Inelastic Issues and pull requests related to direct inelastic
Projects
None yet
Development

No branches or pull requests

1 participant