Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v1.1 of CanSAS standard in SaveCansas1D and LoadCansas1D #7685

Closed
martyngigg opened this issue Apr 8, 2013 · 2 comments
Closed
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@martyngigg
Copy link
Member

This ticket is blocks : TRAC6929

V1.1 of the canSAS XML reduced data file standard is now released (see link below).

http://www.cansas.org/svn/1dwg/trunk/doc/cansas-1d-1_1-manual.pdf

Please could the necessary changes to SaveCansas1D be ticketed, please.

I also attach a non-Mantid-generated example output file to show what the revised data files should look like.

The way I would envisage the new SaveCansas1D algorithm working is that when called to write a reduced 1D data workspace, Mantid checks to see if either or both of the transmissions (sample & can) used to calculate that data have been generated as part of the reduction process. If they have then they should be automatically inserted into the XML file. If they are not present (eg, the user has chosen to reduce data without transmisisons or has deleted both of the transmission workspaces associated with the reduction before choosing to write the file) then the file is written without any SAStransmission_spectrum blocks.

Note that it would be perfectly acceptable for a file to ONLY contain a sample transmission or a can transmission; though the latter case would indeed be odd, it is not forbidden; the former case would be quite common (a reduction without any can subtraction).

Any chance these changes could make it into the May release?

@martyngigg
Copy link
Member Author

This issue was originally trac ticket 6839

@martyngigg
Copy link
Member Author

@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Mantid labels Jun 3, 2015
@martyngigg martyngigg added this to the Release 2.5 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant