Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ConvertInstrumentFile to C++ and enhance #7814

Closed
1 task done
wdzhou opened this issue Apr 30, 2013 · 2 comments
Closed
1 task done

Convert ConvertInstrumentFile to C++ and enhance #7814

wdzhou opened this issue Apr 30, 2013 · 2 comments
Assignees
@wdzhou
Labels
Diffraction Issues and pull requests related to diffraction High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 3.0

Comments

@wdzhou
Copy link
Collaborator

wdzhou commented Apr 30, 2013

This ticket is blocked by :

This ticket is blocks : TRAC7126, TRAC7690, TRAC7696, TRAC7813

Convert algorithm ConvertInstrumentFile to C++.

Consider to rename it to a more self-explanation name.

The default input L1, L2 and 2theta should be re-considered. Make it possible to use 2theta from input .irf file.

Make it possible to import a characterization file to override hard coded d-space range.

A unit test file is required.

Better documentation is expected.

Keywords: Maintenance
@wdzhou
Copy link
Collaborator Author

wdzhou commented Jun 3, 2015

This issue was originally trac ticket 6968

@wdzhou
Copy link
Collaborator Author

wdzhou commented Jun 3, 2015

http://trac.mantidproject.org/mantid/raw-attachment/ticket/6968/pg60_2011B.irf
(uploaded by @wdzhou on 2013-08-20T19:39:37)

@wdzhou wdzhou added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Diffraction Issues and pull requests related to diffraction Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@wdzhou wdzhou self-assigned this Jun 3, 2015
@wdzhou wdzhou added this to the Release 3.0 milestone Jun 3, 2015
@wdzhou wdzhou closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdzhou wdzhou

Labels
Diffraction Issues and pull requests related to diffraction High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.0
Development

No branches or pull requests
1 participant
@wdzhou