Investigate if the beam centre is being used correctly at sans isis #7910
Labels
High Priority
An issue or pull request that if not addressed is severe enough to postponse a release.
SANS
Issues and pull requests related to SANS
Milestone
sans_bugfix
This issue was originally TRAC 7064
Original Reporter: Gesner Passos
While I was looking in detail to the sans isis reduction code, i found strange the relationship between set_beam_finder, get_beam_find_centre,
the reduction steps: _beam_finder and _front_beam_finder, and the pre_process inside sans_reducer that is called at the reducer.
I'm afraid, we are not correctly centering the HAB/front bank detector when this parameter is different from the defined for the rear/main.
Besides, the code inside WavRangeReduction after "for the LOQ instrument, if the beam centers are different, we have to reload the data." is to be properly explained and tested as well.
This ticket must, at least, define a proper systemtest.py to double check this issues. If they are correct beter ;)
The text was updated successfully, but these errors were encountered: