Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if the beam centre is being used correctly at sans isis #7910

Closed
mantid-builder opened this issue May 10, 2013 · 2 comments
Closed
Assignees
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. SANS Issues and pull requests related to SANS
Milestone

Comments

@mantid-builder
Copy link
Collaborator

sans_bugfix
This issue was originally TRAC 7064

Original Reporter: Gesner Passos

While I was looking in detail to the sans isis reduction code, i found strange the relationship between set_beam_finder, get_beam_find_centre,
the reduction steps: _beam_finder and _front_beam_finder, and the pre_process inside sans_reducer that is called at the reducer.

I'm afraid, we are not correctly centering the HAB/front bank detector when this parameter is different from the defined for the rear/main.

Besides, the code inside WavRangeReduction after "for the LOQ instrument, if the beam centers are different, we have to reload the data." is to be properly explained and tested as well.

This ticket must, at least, define a proper systemtest.py to double check this issues. If they are correct beter ;)

@mantid-builder
Copy link
Collaborator Author

@NickDraper (2013-07-26T14:01:43):
Moved to the Backlog after R2.6


@NickDraper (2014-02-14T11:04:54):
Bulk move to assigned at the introduction of the triage step


@NickDraper (2014-03-07T16:20:29):
Ownership handed over to Peter


@PeterParker (2015-04-21T10:31:25):
This is for Richard to investigate the code (he wrote the parts responsible for this). Talk in a SANS Group meeting centred around whether or not the HAB in LOQ is connected to the rear detector.

@mantid-builder mantid-builder added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. SANS Issues and pull requests related to SANS labels Jun 3, 2015
@Matthew-Andrew Matthew-Andrew added this to the Release 3.12 milestone Oct 30, 2017
@NickDraper NickDraper modified the milestones: Release 3.12, Release 3.13 Feb 27, 2018
@Matthew-Andrew
Copy link
Contributor

This is resolved in #22372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. SANS Issues and pull requests related to SANS
Projects
None yet
Development

No branches or pull requests

5 participants