Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANS accept already loaded workspace as input #8066

Closed
mantid-builder opened this issue May 31, 2013 · 1 comment
Closed

SANS accept already loaded workspace as input #8066

mantid-builder opened this issue May 31, 2013 · 1 comment
Labels
SANS Issues and pull requests related to SANS
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Gesner Passos

This ticket is blocks : TRAC6530

The current version of SANS reduction does not accept passing an already loaded workspace as input for the Sample Data, Can, etc.

This option was done in order to make sure that we do not try to 'move the same workspace to its center twice'. Because the movement are relative, this would cause the reduction to work on a fake center and produce a wrong answer.

But, it does have some drawbacks. Sometimes we load data twice to perform a single reduction (wasting time and resources). But, in order to work with the Event Mode data, if we have to split the data, this would mean loading data many times, which would not work nice.

So, my suggestion is to accept workspace as input, but raising exception if the workspace has been moved or rotated so far.


Keywords: SANS

@mantid-builder mantid-builder added the SANS Issues and pull requests related to SANS label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 2.6 milestone Jun 3, 2015
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 7221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SANS Issues and pull requests related to SANS
Projects
None yet
Development

No branches or pull requests

1 participant