Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetSampleMaterial improvements #8125

Closed
1 task done
peterfpeterson opened this issue Jun 10, 2013 · 1 comment
Closed
1 task done

SetSampleMaterial improvements #8125

peterfpeterson opened this issue Jun 10, 2013 · 1 comment
Assignees
Labels
Framework Issues and pull requests related to components in the Framework
Milestone

Comments

@peterfpeterson
Copy link
Member

This ticket is blocked by :

Chatted with Christina a Xiaoping today and many things were pointed out concerning SetSampleMaterial and some related algorithms.

  1. SetSampleMaterial should print units on the values being set
  2. SetSampleMaterial should work on a peaks workspace
  3. SetSampleMaterial should get the unit cell volume from the lattice if it is already attached to the workspace
  4. Clarify language concerning units of SampleNumberDensity
  5. Modify gui for SetSampleMaterial and help so it is clearer which parameters override which
  6. The logging of values should not abbreviate "Cross Section" as "X Section" as some people interpret it to mean the values for x-rays
  7. The scattering cross section does not appear to generate the correct value for "K1-C6-O6". Verify the value and fix the bug.
  8. Setting the chemical formula from C to C60 should do the same thing, currently C60 doesn't work.
@peterfpeterson
Copy link
Member Author

This issue was originally trac ticket 7279

@peterfpeterson peterfpeterson added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@peterfpeterson peterfpeterson self-assigned this Jun 3, 2015
@peterfpeterson peterfpeterson added this to the Release 2.6 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant