Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe getDetectorPosition on Peak object #8232

Closed
OwenArnold opened this issue Jul 1, 2013 · 1 comment
Closed

Safe getDetectorPosition on Peak object #8232

OwenArnold opened this issue Jul 1, 2013 · 1 comment
Assignees
@OwenArnold
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 2.6

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocks : TRAC7325

getDetectorPosition on a peak doesn't check whether the detector is null first. As a result, we're seeing a failure on PeaksOnSurface (http://trac.mantidproject.org/mantid/ticket/7325). The remedy is to add an additional method, which will check whether the detector is null and then throw something that can be caught, rather than getting a segfault. I'm going to leave the existing getDetectorPosition in place, because I don't want to adversely affect performance in other areas.
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 7386

@OwenArnold OwenArnold added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 2.6 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OwenArnold OwenArnold

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 2.6
Development

No branches or pull requests
1 participant
@OwenArnold