Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvertToDiffractionMDWorkspace V1 and V2 produce different Lorentz corrections #8320

Closed
abuts opened this issue Jul 18, 2013 · 2 comments
Closed

ConvertToDiffractionMDWorkspace V1 and V2 produce different Lorentz corrections #8320

abuts opened this issue Jul 18, 2013 · 2 comments
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@abuts
Copy link
Member

abuts commented Jul 18, 2013

This issue was originally TRAC 7475

If one runs Diffraction_Workflow_Test and try to play with algorithm

ConvertToDiffractionMDWorkspace

version (Version=1 or default (2) ) and LorentzCorrections=0 or 1 in rows 104 and 123, the workspaces produced by the algorithm are substantially different.

We currently assume that Version 2 of algorithm with Lorentz corrections works fine, but there are no sufficient evidence for that, as ConvertToDiffractionMDWorkspace version 1 with Lorentz corrections was there for a while.

If would be nice to have certainty that current Lorentz corrections are indeed correct.
@abuts
Copy link
Member Author

abuts commented Feb 14, 2014

@NickDraper (2013-07-26T13:55:02):
Moved to backlog at the code freeze for R2.6

@NickDraper (2014-02-14T11:05:00):
Bulk move to assigned at the introduction of the triage step

@abuts abuts added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@NickDraper
Copy link
Contributor

No action for 3 years - archived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickDraper @abuts