Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvertToMD over subdivides #8324

Closed
peterfpeterson opened this issue Jul 18, 2013 · 2 comments
Closed

ConvertToMD over subdivides #8324

peterfpeterson opened this issue Jul 18, 2013 · 2 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@peterfpeterson
Copy link
Member

This issue was originally TRAC 7479

When using ConvertToMD with single crystal data using the "SCD Event Data Reduction" interface with MAND_306_event.nxs, Max |Q| set to 5, and Apply Lorentz Correction turned on, the data (as viewed in the slice viewer) is over sub-divided. This can be seen by finding peaks and looking at one in the slice view. There will be boxes with zero counts next to ones with thousands of counts.

The suggested fix is that if a subdivision results in boxes with zero counts (when the source box has more than enough counts), don't do the subdivision.

@peterfpeterson
Copy link
Member Author

@NickDraper (2013-07-26T13:55:02):
Moved to backlog at the code freeze for R2.6


@NickDraper (2014-02-14T11:05:00):
Bulk move to assigned at the introduction of the triage step

@peterfpeterson peterfpeterson added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@AndreiSavici
Copy link
Member

I don't think this issue should be fixed. It is the desired behavior. Suppose I start with a large enough workspace, so all the MDEvents are in one side of it. Since by subdividing it would result in empty boxes, not proceeding with redistributing will stop the benefits of the adaptive box structure. If One does not like the binning, one can just rebin the data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

2 participants