Fixes for crashes when running doc tests on Windows #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Y array is one shorter that the X array and the Y value corresponding to the X value is on the left.
martyngigg
added
In Progress
Documentation
It should be possible to end up with a zero dimension array from a workspace.
The output now includes the integrated dimensions.
They always crash on the CI server and need to be investigated.
|
Code changes look good. Just waiting for system tests to pass. |
|
Looks like there was a change to |
The windows ones don't match yet
OwenArnold
added a commit
that referenced
this pull request
Jun 4, 2015
Fixes for crashes when running doc tests on Windows
AndreiSavici
added
the
Patch Candidate
peterfpeterson
removed
the
Patch Candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows debugger caught several out-of-bounds errors that were causing the documentation tests to segfault occasionally. These fixes should cure that.
Tester
Observe that the documentation tests are passing.