Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with boolean properties and GUI #8565

Closed
NickDraper opened this issue Aug 9, 2013 · 1 comment
Closed

Problem with boolean properties and GUI #8565

NickDraper opened this issue Aug 9, 2013 · 1 comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@NickDraper
Copy link
Contributor

This ticket is blocks : TRAC7744

From Michael Reuter:

I have isolated the offending change to work done in this ticket: http://trac.mantidproject.org/mantid/ticket/7441. The following code seems to be the issue:

void AlgorithmDialog::setPreviousValue(QWidget* widget, const QString& propName)
{
QString value = getPreviousValue(propName);

if(value.isEmpty())
return;
...

This seems to assume that all algorithms have been run previously. This is clearly not the case for a fresh Mantid version or if you've just never run the algorithm before. This has the effect on the checkboxes that are supposed to have default true values that they are never marked as checked since setValue is not called further down. Reestablishing the old logic breaks the change intended for the ticket. This needs to be rethought and redone.

M

On 08/08/2013 03:14 PM, Campbell, Stuart I. wrote:
Hi,

Has anyone else noticed that if you have a clean configuration (I.e. A blank ~/.config/Mantid) and you run any algorithm that has a boolean property with a default of true (e.g. LoadEventNexus) that the algorithm GUI doesn't not show this property as checked.

Cheers
Stu

Dr Stuart Campbell
Neutron Data Analysis and Visualisation Division
Oak Ridge National Laboratory
1 Bethel Valley Road, PO Box 2008
Oak Ridge, TN 37831-6475, USA

mobile: +1-865-360-6733
email: campbellsi@ornl.gov<mailto:campbellsi@ornl.gov>


Keywords: PatchCandidate

@NickDraper
Copy link
Contributor Author

This issue was originally trac ticket 7720

@NickDraper NickDraper added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. GUI labels Jun 3, 2015
@NickDraper NickDraper added this to the Release 2.6.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant