Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algorithms accessing the AnalysisDataService when they shouldn't be #8623

Closed
mantid-builder opened this issue Aug 19, 2013 · 1 comment
Closed

Algorithms accessing the AnalysisDataService when they shouldn't be #8623

mantid-builder opened this issue Aug 19, 2013 · 1 comment
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 3.2

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Russell Taylor

In general, algorithms shouldn't need to go directly to the ADS as the Algorithm base class takes care of most of that side of things.

This task is to check all algorithms that have a direct call to the AnalysisDataService and correct them if appropriate. The algorithms in Crystal seem to be particularly guilty.

Keywords: Maintenance
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 7778

@mantid-builder mantid-builder added Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@mantid-builder