Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Shapes don't render in the CreateSampleShape GUI #8647

Closed
mantid-builder opened this issue Aug 22, 2013 · 3 comments
Closed

Some Shapes don't render in the CreateSampleShape GUI #8647

mantid-builder opened this issue Aug 22, 2013 · 3 comments
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@mantid-builder
Copy link
Collaborator

This issue was originally TRAC 7802

Original Reporter: Keith Brown

This ticket is blocks : TRAC3737

There are some shapes in the CreateSampleShape GUI that won't render either on their own or as part of an operation.

The affected shapes are:
Hexahedron
Cylinder Ring Slice
Cone

Hexahedrons and Cones should render and they're useful in samples and should be fixed by this ticket.

Cylinder Ring Slices aren't as useful in samples, but if they're fixed by fixing Hexahedrons and Cones, great, however if they would require specific extra work in order to get them to render, they should actually be considered to be removed as an option in the CreateSampleShape GUI as they're unlikely to be used in samples

@mantid-builder
Copy link
Collaborator Author

Keith Brown (2013-08-22T16:07:06):
Looking for cause of non-render

Currently breakpointing the suspect area.

Refs http://trac.mantidproject.org/mantid/ticket/7802

84d5050


Keith Brown (2013-08-29T14:32:43):
Found out that the culprit for the cone is most likely because the bounding box is returning wrongly.


Keith Brown (2013-08-30T08:26:01):
Added .h files to cmake list

All the primitive shape's .h files were missing from cmake. Added them even though it does nothing functionally

Refs http://trac.mantidproject.org/mantid/ticket/7802

ffc2799


Keith Brown (2013-08-30T08:26:01):
Tidied up some code after my attepts to find the cause

The cause of the Cone not rendering is that it's bounding box isn't calculated and it just returns the bounds given to it. So it is actually rendering, it's jsut so small not even a pixel is small enough to represent it.

As calculating this is beyond my skill i'm going to have to leave this ticket to someone else, so i've fixed the code i'd altered in my search for the problem and tidied some other areas.

Refs http://trac.mantidproject.org/mantid/ticket/7802

d1ab016


@NickDraper (2013-10-15T15:45:26):
Moved out to backlog as not enough time in R3.0

@mantid-builder mantid-builder added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@NickDraper NickDraper removed their assignment Sep 1, 2020
@stale
Copy link

stale bot commented Feb 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 28, 2021
@stale
Copy link

stale bot commented Mar 7, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

3 participants