Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstrumentTest.py does nothing #8845

Closed
mantid-builder opened this issue Sep 23, 2013 · 1 comment
Closed

InstrumentTest.py does nothing #8845

mantid-builder opened this issue Sep 23, 2013 · 1 comment
Assignees
@martyngigg
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 3.0

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Gesner Passos

The unit test for the export of the instrument, does nothing.

Code/Mantid/Framework/PythonInterface/test/python/mantid/geometry/InstrumentTest.py

The class InstrumentTest must inherit from unittest.TestCase.

If you do so, you will see that this 'unit test' is broken.

If possible, add also a security check for getBaseInstrument. Changes made in http://trac.mantidproject.org/mantid/ticket/7607 broke that exported method and we were no aware of.
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8000

@mantid-builder mantid-builder added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.0 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martyngigg martyngigg

Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.0
Development

No branches or pull requests
2 participants
@martyngigg @mantid-builder