Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fields on the sample object #8857

Closed
peterfpeterson opened this issue Sep 24, 2013 · 3 comments
Closed

More fields on the sample object #8857

peterfpeterson opened this issue Sep 24, 2013 · 3 comments
Assignees
Labels
Diffraction Issues and pull requests related to diffraction

Comments

@peterfpeterson
Copy link
Member

This issue was originally TRAC 8012

This is to add the fields to the Material and to the algorithm SetSampleMaterial.

  • In SetSampleMaterial, add a field for the mass density which will convert the value to a number density if sample composition is known, and generate an exception if there isn't a composition
  • Add a field for the packing fraction. This has valid values 0<frac<=1.
  • Add a field for the mass
  • Number density = mass density *6.022e23 / Total atomic mass (when mass density is in g/cm^3)
@peterfpeterson
Copy link
Member Author

@NickDraper (2014-02-02T15:34:49):
Moved to backlog at the end of Release 3.1


@NickDraper (2014-02-14T11:05:00):
Bulk move to assigned at the introduction of the triage step

@peterfpeterson peterfpeterson added the Diffraction Issues and pull requests related to diffraction label Jun 3, 2015
@peterfpeterson
Copy link
Member Author

Modified based on the current state of the repository and a found equation

@peterfpeterson
Copy link
Member Author

The new version of this is #25389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

No branches or pull requests

2 participants