Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ConvertUnits #8874

Closed
mantid-roman opened this issue Sep 26, 2013 · 3 comments
Closed

Issue with ConvertUnits #8874

mantid-roman opened this issue Sep 26, 2013 · 3 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@mantid-roman
Copy link
Contributor

This issue was originally TRAC 8029

From Pascal:

If you make a mistake by choosing Direct instead of elastic, it seems to remember somehow and subsequent conversion don;t work, see below.
This is not urgent as you can reload from scartch and start with proper "elastic" option again and it works.

######################################################################
#Python Script Generated by GeneratePythonScript Algorithm
######################################################################
LoadRaw(Filename=r'/archive/ndxwish/Instrument/data/cycle_13_3/WISH00025470.raw', OutputWorkspace='25470')
CropWorkspace(InputWorkspace='25470',OutputWorkspace='25470',XMin='6000',XMax='99000')
ConvertUnits(InputWorkspace='25470',OutputWorkspace='25470',Target='Wavelength')
ConvertUnits(InputWorkspace='25470',OutputWorkspace='25470',Target='TOF')
ConvertUnits(InputWorkspace='25470',OutputWorkspace='25470',Target='Wavelength')
ConvertUnits(InputWorkspace='25470',OutputWorkspace='25470',Target='Wavelength')
ConvertUnits(InputWorkspace='25470',OutputWorkspace='25470',Target='TOF')
ConvertUnits(InputWorkspace='25470',OutputWorkspace='25470',Target='Wavelength')

@mantid-roman
Copy link
Contributor Author

@NickDraper (2014-02-14T11:05:00):
Bulk move to assigned at the introduction of the triage step

@mantid-roman mantid-roman added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@NickDraper NickDraper self-assigned this Feb 12, 2016
@NickDraper
Copy link
Contributor

The memory is there for a reason to allow subsequent calls to not need that setting to be set.

However this is a good point. What to do??
We could put some protection in that disallows direct without an efixed value.
Or add a boolean option to override saved values

Assigned to PM for now

@NickDraper
Copy link
Contributor

The test above works fine now, looking at the code there appears to be protection to only store efixed if it is actually specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

2 participants