Instances of AxesDialog aren't being disposed of efficently

[mantid-builder]

This issue was originally TRAC 8035

Original Reporter: Keith Brown

This ticket is blocked by :

• TRAC7865

During ticket http://trac.mantidproject.org/mantid/ticket/7865 the memory usage of AxesDialog increased, but it was assumed that this would be OK as the memory would be freed up once the dialog is closed. This is not the case.

What seems to be happening is that the instances of AxesDialog are being parented by the graph and are still hanging about in memory until the graph window is closed, when they really should be deleted once the dialog is closed.

An example of one areas that need improvement:

QDialog* ApplicationWindow::showScaleDialog()
{
  MdiSubWindow *w = activeWindow();
  if (!w)
    return 0;

  if (w->isA("MultiLayer")){
    if (dynamic_cast`<MultiLayer*>`(w)->isEmpty())
      return 0;

    Graph* g = dynamic_cast`<MultiLayer*>`(w)->activeGraph();
    if (g->isPiePlot()){
      QMessageBox::warning(this, tr("MantidPlot - Warning"), tr("This functionality is not available for pie plots!"));//Mantid
      return 0;
    }

    AxesDialog* ad = new AxesDialog(this,g);
    ad->exec();
    return ad;
  } else if (w->isA("Graph3D"))
    return showPlot3dDialog();

  return 0;
}

At the time of writing, http://trac.mantidproject.org/mantid/ticket/7865 is still in progress so it might be wise to leave this until the improvements have been made.

---

Keywords: Maintenance

[mantid-builder]

@NickDraper (2014-02-14T11:07:58):
bulk move to assigned at the into of the triage step

---

Keith Brown (2014-06-26T13:07:08):
not going to get this done before i leave, leaving to anyone