Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SANS remove spec_min and spec_max for options #8899

Closed
1 task done
mantid-builder opened this issue Sep 30, 2013 · 1 comment
Closed
1 task done

SANS remove spec_min and spec_max for options #8899

mantid-builder opened this issue Sep 30, 2013 · 1 comment
Labels
SANS Issues and pull requests related to SANS
Milestone
Release 3.0

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Gesner Passos

This ticket is blocked by :

This ticket is blocks : TRAC8052

We keep spec_min and spec_max for loading SANS data in order to pass on as SpectrumMin and SpectrumMax eventhough they are not used, or just passed as None values.

There is only one single case where they can be used, is to load SANS2D files collected in 2009 (before run 568).

Now, that they are moving towards EventData, which does not provide this option, I suggest removing these attributes.
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8054

@mantid-builder mantid-builder added the SANS Issues and pull requests related to SANS label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.0 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.0
Development

No branches or pull requests
1 participant
@mantid-builder