Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LoadDetectorInfo from DirectEnergyConversion.py script #8902

Closed
martyngigg opened this issue Oct 1, 2013 · 1 comment
Closed

Remove LoadDetectorInfo from DirectEnergyConversion.py script #8902

martyngigg opened this issue Oct 1, 2013 · 1 comment
Assignees
Labels
Direct Inelastic Issues and pull requests related to direct inelastic
Milestone

Comments

@martyngigg
Copy link
Member

The algorithm does the following:

  • updates detector positions based on input file positions;
  • sets component parameters for the tube pressure & wall thickness and
  • adjusts X bins by a detector delay time.

This behaviour needs splitting up. The tube pressure, wall thickness should be in the instrument definition (much as the SNS instruments do now), along with the detector delay time. The UpdateInstrumentFromFile algorithm already accepts RAW,ISIS Nexus and others. It simply needs extending to read the block from an ISIS event nexus file.

@martyngigg
Copy link
Member Author

This issue was originally trac ticket 8057

@martyngigg martyngigg added the Direct Inelastic Issues and pull requests related to direct inelastic label Jun 3, 2015
@martyngigg martyngigg self-assigned this Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.0 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Direct Inelastic Issues and pull requests related to direct inelastic
Projects
None yet
Development

No branches or pull requests

1 participant