Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Filtering can leave 0 log entries #9057

Closed
NickDraper opened this issue Oct 24, 2013 · 3 comments
Closed

Event Filtering can leave 0 log entries #9057

NickDraper opened this issue Oct 24, 2013 · 3 comments
Assignees
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@NickDraper
Copy link
Contributor

This issue was originally TRAC 8212

Reported by Rob Dlagleish.

This definitely happens with filtering by log, but might happen with time and filterevents as well.

If you filter the data fine enough so that loging on change does not have an entry within the filtered region you get 0 entries in the log while we should be propogating the last valid log value in (for each filtered section).


rnum=28511

Load(str(rnum),OutputWorkspace=str(rnum),LoadMonitors='1')

ws=mtd[str(rnum)]
r= ws.getRun()
time_array = r.getLogData("proton_charge").times
value_array = r.getLogData("proton_charge").value

FilterByLogValue(str(rnum),'Theta',0.295,0.305,OutputWorkspace=str(rnum)+"_03deg")
Rebin(str(rnum)+"_03deg","5.0,20.0,100000.0",PreserveEvents=0,OutputWorkspace=str(rnum)+"_03deg_Hist")


@NickDraper
Copy link
Contributor Author

@NickDraper (2013-11-06T15:16:27):
This case is when the logs only log the value on change, and there were no changes in the filtered period. So the fix is to propagate the last valid value into the start of the filtered period.


@NickDraper (2014-02-14T11:04:54):
Bulk move to assigned at the introduction of the triage step

@NickDraper NickDraper added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@stale
Copy link

stale bot commented Feb 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 24, 2021
@stale
Copy link

stale bot commented Mar 3, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

2 participants