Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SaveIsawPeaks for non-rectangular detectors #9085

Closed
OwenArnold opened this issue Oct 28, 2013 · 3 comments
Closed

SaveIsawPeaks for non-rectangular detectors #9085

OwenArnold opened this issue Oct 28, 2013 · 3 comments
Assignees
@samueljackson92
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.

Comments

@OwenArnold
Copy link
Contributor

This issue was originally TRAC 8240

http://www.mantidproject.org/SaveIsawPeaks is not working for non-rectangular instruments, such as WISH.

  • Plan A. Algorithm should be made to work for non-rectangular detectors if possible
  • Plan B. Algorithm should give-up and suggest using SaveNexus if not possible (above). See http://trac.mantidproject.org/mantid/ticket/4443
  • Plan B. In addition to the step above. The documentation for this algorithm should inform users on what this algorithm is capable of working for.
@OwenArnold OwenArnold added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@NickDraper
Copy link
Contributor

It is worth checking what the current state of this is

@samueljackson92
Copy link
Contributor

@NickDraper Pascal indicated today that this may have been done. Worth checking.

@samueljackson92 samueljackson92 added the Low Priority Things that you don't ever want to be done. label Sep 13, 2016
@samueljackson92
Copy link
Contributor

This looks like I has been generalised to support non-rectangular detectors, but there seems to be a lot of code hard coded to WISH. I wonder if it could be made more general? In any case I'm moving this to low priority.

@samueljackson92 samueljackson92 added this to the Temporary Holding milestone Oct 12, 2016
@NickDraper NickDraper removed this from the Temporary Holding milestone Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samueljackson92 samueljackson92

Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NickDraper @OwenArnold @samueljackson92 @raquelalvarezbanos