Clear memory leaks in the GeometryTest package

[mantid-builder]

Original Reporter: Russell Taylor

This ticket is blocks : TRAC8360

The SNS Jenkins has a [https://builds.sns.gov/job/ornl_valgrind_develop valgrind job] which uses the unit tests as a hook into exercising the Mantid code itself. This of course means that it picks up any leaks in the test code as well.

Using this job and/or valgrind runs of your own, eliminate all the leaks/errors that come out of the test code itself. I've created this as an isolated ticket because I'd like to get a clear view of the errors we have in the actual Mantid code. '''All changes to this ticket should only be to code in the Framework/Geometry/test/ directory'''!

When working on this, don't just add delete calls - consider whether the leaking call really needs to be a heap allocation; create the object on the stack if not.

---

Keywords: Maintenance

[mantid-builder]

This issue was originally trac ticket 8356