Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick to Lam #9217

Closed
OwenArnold opened this issue Nov 5, 2013 · 2 comments
Closed

Quick to Lam #9217

OwenArnold opened this issue Nov 5, 2013 · 2 comments
Assignees
@OwenArnold
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 3.1

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocks : TRAC8371

quick.py has a toLam function. We need to convert the entire of quick to an algorithm (http://trac.mantidproject.org/mantid/ticket/8371). This is best done bottom-up, which means converting toLam to an algorithm first or refactoring it out to a separate module

This should be quite safe to do, as I've already provided test coverage for the quick scripts.

toLam is a horrible function, and should definitely be refactored in the process of moving it anywhere.
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 8372

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.1 milestone Jun 3, 2015
@OwenArnold
Copy link
Contributor Author

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8372/ReflectometryQuick.py
(uploaded by @OwenArnold on 2013-11-26T12:41:06)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OwenArnold OwenArnold

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
1 participant
@OwenArnold