Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct SampleGeomCor to not use protected members of ISISReducer #9299

Closed
1 task done
mantid-builder opened this issue Nov 15, 2013 · 2 comments
Closed
1 task done

Correct SampleGeomCor to not use protected members of ISISReducer #9299

mantid-builder opened this issue Nov 15, 2013 · 2 comments
Labels
SANS Issues and pull requests related to SANS
Milestone
Release 3.1

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Gesner Passos

This ticket is blocked by :

Currently it gets access to _sample_run. But SampleGeomCor should not know about it, it is a protected member. The pacth attached should address the case, but can not be aplied before http://trac.mantidproject.org/mantid/ticket/8443
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8455

@mantid-builder
Copy link
Collaborator Author

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8455/patch_for_sans_reduction_steps.patch
(uploaded by Gesner Passos on 2013-11-15T10:42:20)

@mantid-builder mantid-builder added the SANS Issues and pull requests related to SANS label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
1 participant
@mantid-builder