Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor out toLam #9309

Closed
OwenArnold opened this issue Nov 18, 2013 · 1 comment
Closed

refactor out toLam #9309

OwenArnold opened this issue Nov 18, 2013 · 1 comment
Assignees
@eXeC64
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 3.3

Comments

@OwenArnold
Copy link
Contributor

quick.py has a toLam function. We need to convert the entire of quick to an algorithm (http://trac.mantidproject.org/mantid/ticket/8371). This is best done bottom-up, which means converting toLam to an algorithm first or refactoring it out to a separate module

This should be quite safe to do, as I've already provided test coverage for the quick scripts.

toLam is a horrible function, and should definitely be refactored in the process of moving it anywhere.
@OwenArnold OwenArnold added the Reflectometry Issues and pull requests related to reflectometry label Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.3 milestone Jun 3, 2015
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 8465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eXeC64 eXeC64

Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.3
Development

No branches or pull requests
2 participants
@eXeC64 @OwenArnold