Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix l2q instrument setup usage #9360

Closed
OwenArnold opened this issue Nov 26, 2013 · 1 comment
Closed

Fix l2q instrument setup usage #9360

OwenArnold opened this issue Nov 26, 2013 · 1 comment
Assignees
@OwenArnold
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 3.1

Comments

@OwenArnold
Copy link
Contributor

l2q.py is hard-coded with an instrument reference frame for the MoveComponent correction calculations.

For instruments that do not share the same reference frame, the calculation will yield completely different and incorrect results.

Use the ReferenceFrame type associated with the instrument to correctly apply the corrections without having to know the specifics of the instrument setup.
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 8516

@OwenArnold OwenArnold added the Reflectometry Issues and pull requests related to reflectometry label Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OwenArnold OwenArnold

Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
1 participant
@OwenArnold