Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LoadParameterFile access instrument in proper manner #9365

Closed
KarlPalmen opened this issue Nov 27, 2013 · 1 comment
Closed

Make LoadParameterFile access instrument in proper manner #9365

KarlPalmen opened this issue Nov 27, 2013 · 1 comment
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Maintenance

Comments

@KarlPalmen
Copy link
Contributor

This issue was originally TRAC 8521

Line 107 in LoadParameterFile has a dodgy pointer cast as explained in comment above it

  // TODO: Refactor to remove the need for the const cast
  Instrument_sptr instrument = boost::const_pointer_cast`<Instrument>`(localWorkspace->getInstrument()->baseInstrument());

This ticket is basically that TODO.

It has not yet caused a known problem, but the functionality of the code is useful for putting parameters into a workspace (e.g. from a fullprof file).

Keywords: maintenance
@KarlPalmen
Copy link
Contributor Author

@NickDraper (2014-02-14T11:07:54):
bulk move to assigned at the into of the triage step

@KarlPalmen KarlPalmen added Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@NickDraper NickDraper added this to the Release 3.6 milestone Oct 2, 2015
@NickDraper NickDraper modified the milestones: Release 3.6, Release 3.7 Jan 22, 2016
@NickDraper NickDraper modified the milestone: Release 3.7 May 20, 2016
@SimonHeybrock SimonHeybrock mentioned this issue Sep 28, 2017
Merged
7 tasks
@peterfpeterson peterfpeterson added this to Next in Maintenance Nov 20, 2018
@peterfpeterson peterfpeterson moved this from Next to To do in Maintenance Nov 20, 2018
Maintenance automation moved this from To do to Done Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues and pull requests related to components in the Framework Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Mantid Maintenance
Status: Done
Maintenance
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterfpeterson @NickDraper @KarlPalmen