Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in any systemtest stops the entire sset from running #9377

Closed
martyngigg opened this issue Nov 29, 2013 · 1 comment
Closed
Assignees
Labels
Framework Issues and pull requests related to components in the Framework
Milestone

Comments

@martyngigg
Copy link
Member

This is example output from a recent jenkins run of the system tests:

+ python InstallerTests.py -o
FrameworkManager-[Notice] Welcome to Mantid version 3.0.20131128.1550 - Manipulation and Analysis Toolkit for Instrument Data
FrameworkManager-[Notice] Please cite Mantid in your publications using: http://dx.doi.org/10.5286/Software/Mantid
Traceback (most recent call last):
  File "runSystemTests.py", line 73, in `<module>`
    testsInclude=options.testsInclude, testsExclude=options.testsExclude)
  File "../StressTestFramework/stresstesting.py", line 757, in __init__
    self._tests = self.loadTestsFromDir(test_dir)
  File "../StressTestFramework/stresstesting.py", line 824, in loadTestsFromDir
    tests.extend(self.loadTestsFromModule(os.path.join(test_dir,file)))
  File "../StressTestFramework/stresstesting.py", line 838, in loadTestsFromModule
    mod = imp.load_module(modname, pyfile, filename, ("","",imp.PY_SOURCE))
  File "/home/mantidlog/jenkins/workspace/is_test_rhel6_develop/SystemTests/AnalysisTests/ReflectometryQuickPointDetectorSURF.py", line 16
    try
      ^
SyntaxError: invalid syntax
Starting system tests
Using installer /home/mantidlog/jenkins/workspace/is_test_rhel6_develop/InstallerTesting/mantidnightly-3.0.20131128.1550-1.el6.x86_64.rpm
Installing package '/home/mantidlog/jenkins/workspace/is_test_rhel6_develop/InstallerTesting/mantidnightly-3.0.20131128.1550-1.el6.x86_64.rpm'
Application path /opt/mantidnightly/bin/MantidPlot
MantidPlot directory /opt/mantidnightly/bin
Pointing MANTIDPATH at MantidPlot directory /opt/mantidnightly/bin
3.0.20131128.1550 (Thu, 28 Nov 2013)

It hit a syntax error when loading a test and subsequently the whole thing fell over. We should catch these and report them as errors in the tests themselves.

@martyngigg
Copy link
Member Author

This issue was originally trac ticket 8533

@martyngigg martyngigg added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@martyngigg martyngigg self-assigned this Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant