Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmission Workflow Algorithm #9433

Closed
OwenArnold opened this issue Dec 10, 2013 · 1 comment
Closed

Transmission Workflow Algorithm #9433

OwenArnold opened this issue Dec 10, 2013 · 1 comment
Assignees
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocks : TRAC8616

There is a lack of flexibility in the current quick script (and also now http://trac.mantidproject.org/mantid/ticket/8371) that the users don't like. Essentially the generation and normalisation of transmission runs is hard-coded. The algorithms/scripts both make and use the Transmission runs. It would be better to separate out the building of the Transmission runs from their usage. This would also collapse the existing ReflectometryReductionOne algorithm down by quite a bit.

  • Create a new CreateTransmissionCorrection workflow algorithm. Fortunately, I knew that this work would be upon us so most of the Transmission Correction functionality is in a stand-alone method. Things like toLam may make a base algorithm.
  • Make ReflectometryReductionOne use CreateTransmissionCorrection
  • If the workspace 'FirstTransmissionRun' appears to be in units of wavelength. Assume that it has already been reduced and just use it as the denominator in the normalisation step. Otherwise if it's in TOF, run the TransmissionCorrection procedures. Otherwise, fall over and die (loudly).
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 8589

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

1 participant