Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiffRotDiscreteCircle: move initialization steps from constructor to init method #9475

Closed
jmborr opened this issue Dec 17, 2013 · 1 comment
Closed

DiffRotDiscreteCircle: move initialization steps from constructor to init method #9475

jmborr opened this issue Dec 17, 2013 · 1 comment
Assignees
@jmborr
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Milestone
Release 3.1

Comments

@jmborr
Copy link
Member

jmborr commented Dec 17, 2013

Both DiffRotDiscreteCircle and its members (ElasticDiffRotDiscreteCircle and InelasticDiffRotDiscreteCircle) carry out the initialization steps in their corresponding constructors. When object creation is required, but not initialization, these steps amount to a significant overhead.

Note to Tester: Follow the notes "for the tester" found in the description of ticket http://trac.mantidproject.org/mantid/ticket/8508. Run the attached python script there to verify that the changes implemented in this ticket did not affect the fitting procedure.
@jmborr
Copy link
Member Author

jmborr commented Jun 3, 2015

This issue was originally trac ticket 8631

@jmborr jmborr added the Indirect/Inelastic Issues and pull requests related to indirect or inelastic label Jun 3, 2015
@jmborr jmborr self-assigned this Jun 3, 2015
@jmborr jmborr added this to the Release 3.1 milestone Jun 3, 2015
@jmborr jmborr closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmborr jmborr

Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
1 participant
@jmborr