Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icat external download file creation #9571

Closed
1 task done
mantid-builder opened this issue Jan 17, 2014 · 1 comment
Closed
1 task done

icat external download file creation #9571

mantid-builder opened this issue Jan 17, 2014 · 1 comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Jay Rainey

This ticket is blocked by :

If the user attempts to download a file from the catalog and does not have access to the archives it's downloaded over HTTPS.

However, if an error occurs then the content of this is written to the name of the file the user tried to download.

This can be mis-leading and lead to problems. Especially if the user presses "Load" as the file is downloaded and then attempted to load into Mantid, which will not work.

As such, we should never create a file nor write to it if an error occurs on the IDS. Instead, we must output a valid error message to the user. (The contents of which were previously written to a file).


Keywords: ICAT

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8727

@mantid-builder mantid-builder added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant