Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fit function back-to-back exponential convoluted with psuedo voigt #9588

Closed
wdzhou opened this issue Jan 23, 2014 · 6 comments
Closed
Assignees
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@wdzhou
Copy link
Collaborator

wdzhou commented Jan 23, 2014

This issue was originally TRAC 8744

This ticket is blocks : TRAC8745

Implement a fit function back to back exponential convoluted with pseduo-voigt as an extension of existing fit function BackToBackExponential, which only is convoluted with Gaussian

@wdzhou
Copy link
Collaborator Author

wdzhou commented Dec 8, 2014

@wdzhou (2014-01-31T04:03:47):
Starting to implement BackToBackExponentialPV. Refs http://trac.mantidproject.org/mantid/ticket/8744.

Starting to implement BackToBackExponentialPV.
The code is migrated from BacktoBackExponential.
Some changes have been implemented.
But it is not finished yet.

6659add


@NickDraper (2014-02-02T15:34:46):
Moved to backlog at the end of Release 3.1


@wdzhou (2014-02-03T16:48:23):
Finished implementation of the function. Refs http://trac.mantidproject.org/mantid/ticket/8744.

936c2af


@wdzhou (2014-02-03T21:13:45):
Added some unit tests. Refs http://trac.mantidproject.org/mantid/ticket/8744.

eba451a


@wdzhou (2014-02-05T19:36:36):
Fixed unit test. Refs http://trac.mantidproject.org/mantid/ticket/8744.

f5e62cc


@wdzhou (2014-02-13T21:18:21):
Modified doc in wiki. Refs http://trac.mantidproject.org/mantid/ticket/8744.

3e4d8f8


@wdzhou (2014-02-13T21:18:21):
Added one more unit test. Refs http://trac.mantidproject.org/mantid/ticket/8744.

97afd4e


@wdzhou (2014-02-14T14:37:46):
Minor modification on how to calculate peak extent. Refs http://trac.mantidproject.org/mantid/ticket/8744.

e204f6b


@wdzhou (2014-02-14T14:39:42):
== For tester ==
Find some data from instruments using back-to-back exponential convoluted with pseudo-voigt as peak profile. Then using this function to fit some peak.


@Anders-Markvardsen (2014-02-18T10:12:38):
ISIS HRPD focused processed nexus file


@Anders-Markvardsen (2014-02-18T10:27:42):

  1. Load attached hrp55500.nxs file
  2. Plot workspace hrp55500_2 for example
  3. Add LinearBackground and one BackToBackExponentialPV peak

When I try to adjust the width graphically I get the error message "Peak width cannot be equal or less than zero", see attaced picture1.png

In another attempt, good new is that I did get a fit, but the parameters ! and B does not change. Also if I change the values of these manually as far as I can tell the peak shape does not change when I do plot guess.

When I select a non-zero value for Gamma, e.g. 1.0, and then to a fit I, the fit takes a lot longer and a lot of red lines are outputted, e.g:

rying to set a NaN or infinity value (1.#QNAN) to parameter Gamma
Trying to set a NaN or infinity value (1.#QNAN) to parameter I
Trying to set a NaN or infinity value (1.#QNAN) to parameter A
Trying to set a NaN or infinity value (1.#QNAN) to parameter B
Trying to set a NaN or infinity value (1.#QNAN) to parameter X0
Trying to set a NaN or infinity value (1.#QNAN) to parameter S
Trying to set a NaN or infinity value (1.#QNAN) to parameter Gamma
Trying to set a NaN or infinity value (1.#QNAN) to parameter I
Trying to set a NaN or infinity value (1.#QNAN) to parameter A
Trying to set a NaN or infinity value (1.#QNAN) to parameter B
Trying to set a NaN or infinity value (1.#QNAN) to parameter X0
Trying to set a NaN or infinity value (1.#QNAN) to parameter S
Trying to set a NaN or infinity value (1.#QNAN) to parameter Gamma
Trying to set a NaN or infinity value (1.#QNAN) to parameter I
Trying to set a NaN or infinity value (1.#QNAN) to parameter A
Trying to set a NaN or infinity value (1.#QNAN) to parameter B
Trying to set a NaN or infinity value (1.#QNAN) to parameter X0
Trying to set a NaN or infinity value (1.#QNAN) to parameter S
Trying to set a NaN or infinity value (1.#QNAN) to parameter Gamma
Trying to set a NaN or infinity value (1.#QNAN) to parameter I
Trying to set a NaN or infinity value (1.#QNAN) to parameter A
Trying to set a NaN or infinity value (1.#QNAN) to parameter B
Trying to set a NaN or infinity value (1.#QNAN) to parameter X0
Trying to set a NaN or infinity value (1.#QNAN) to parameter S
Trying to set a NaN or infinity value (1.#QNAN) to parameter Gamma
Trying to set a NaN or infinity value (1.#QNAN) to parameter I
Trying to set a NaN or infinity value (1.#QNAN) to parameter A
Trying to set a NaN or infinity value (1.#QNAN) to parameter B
Trying to set a NaN or infinity value (1.#QNAN) to parameter X0
Trying to set a NaN or infinity value (1.#QNAN) to parameter S
Trying to set a NaN or infinity value (1.#QNAN) to parameter Gamma
Trying to set a NaN or infinity value (1.#QNAN) to parameter I
Trying to set a NaN or infinity value (1.#QNAN) to parameter A
Trying to set a NaN or infinity value (1.#QNAN) to parameter B
Trying to set a NaN or infinity value (1.#QNAN) to parameter X0
Trying to set a NaN or infinity value (1.#QNAN) to parameter S
Trying to set a NaN or infinity value (1.#QNAN) to parameter Gamma
Trying to set a NaN or infinity value (1.#QNAN) to parameter I


@NickDraper (2014-12-08T10:25:31):
Moved to the backlog at the code freeze of R3.3

@wdzhou
Copy link
Collaborator Author

wdzhou commented Jun 3, 2015

@wdzhou wdzhou added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@wdzhou wdzhou self-assigned this Jun 3, 2015
@FedeMPouzols
Copy link
Contributor

We have a function called Bk2BkExpConvPV which is available in Mantid. What's the difference between Bk2BkExpConvPV and the one proposed in this ticket (BackToBackExponentialPV)?

@Anders-Markvardsen : for documentation purposes it would be nice to clarify what "back-to-back exponential / convoluted with..." functions are available, their variants and how exactly they're defined in Mantid (equations and references). There are no documentation pages for these functions, but we have this wiki page: http://www.mantidproject.org/BackToBackExponentialPV

Related to this, there are these two other functions: NeutronBk2BkExpConvPVoigt and ThermalNeutronBk2BkConvPVoigt (#9589).

@Anders-Markvardsen
Copy link
Member

@FedeMPouzols there is a rst for BackToBackExponential, see http://docs.mantidproject.org/nightly/fitfunctions/BackToBackExponential.html for its wiki translation.

You can also find this documentation by clicking on 'Fit functions' on http://www.mantidproject.org/Documentation.

@wdzhou is this issue now a duplicate? I.e. has this function has now been implemented as Bk2BkExpConvPV?

The wiki http://www.mantidproject.org/BackToBackExponentialPV was probably written before we introduced rst documentation for fit functions, and this wiki page should be deleted and its content used for a rst documentation page for the back to back exp PV fit function implementation

@stale
Copy link

stale bot commented Feb 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 24, 2021
@stale
Copy link

stale bot commented Mar 3, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

3 participants