Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching Spectra in ReflectometryReductionOne #9633

Closed
OwenArnold opened this issue Jan 30, 2014 · 1 comment
Closed

Matching Spectra in ReflectometryReductionOne #9633

OwenArnold opened this issue Jan 30, 2014 · 1 comment
Assignees
@OwenArnold
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 3.1

Comments

@OwenArnold
Copy link
Contributor

ReflectometryReductionOne has the ability to accept Transmission Workspaces for normalisation. The current behaviour is that the spectrum numbers are taken from the numerator workspace, and used to find and crop the correct spectra out of the denominator (transmission) workspace. If spectrum numbers cannot be found that match up, the algorithm exits without completing.

The behaviour requested by Tim Charlton is that we have an optional less-severe penalty for having mismatched spectrum numbers and allow the division to proceed on the basis of workspace index matching. This would be an optional switch, which would be On by default, and would still log a warning message that users could heed.

Switch would be something like 'StrictSpectrumChecking'. Users would have to actively disable it.

The code this will affect is in ReflectometryReductionOne, where createWorkspaceIndexListFromDetectorWorkspace is used.
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 8789

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OwenArnold OwenArnold

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
1 participant
@OwenArnold