Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LoadMuonNexus to use MuonGroupDetectors for AutoGroup #9683

Closed
mantid-builder opened this issue Feb 3, 2014 · 1 comment
Closed

Refactor LoadMuonNexus to use MuonGroupDetectors for AutoGroup #9683

mantid-builder opened this issue Feb 3, 2014 · 1 comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Milestone
Release 3.2

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Arturs Bekasovs

This ticket is blocks : TRAC8835

Currently AutoGroup is implemented as a separate piece of code. For sake of consistency, it should be better to use loaded grouping (which we get for DetectorGroupingTable output option) and just pass it to MuonGroupDetectors. It will allow to localize any future problems and avoid something like this: http://trac.mantidproject.org/mantid/ticket/8835.

Should make sure the functionality is covered by unit tests before making any changes.

Keywords: Maintenance
@mantid-builder mantid-builder added the Muon Issues and pull requests related to muons label Jun 3, 2015
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8839

@mantid-builder mantid-builder added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@mantid-builder