Error in SplineWorkspace

[mantid-builder]

Original Reporter: Russell Taylor

The following code in SplineWorkspace.cpp (starting at line 88) came to my attention because coverity scan complained about dereferencing a null pointer:

  double* yValues(0);
  m_cspline->derivative1D(yValues, xValues, nData, 2);
  for(size_t i=0;i<nData;i++)
  {
    out->set(i,0,1.);
    out->set(i,1,xValues[i]);
    out->set(i,2,yValues[i]);
  }

yValues needs to be an array, but is not declared as such. The best approach here would be to declare it as a local std::vector and then pass its address to derivative1D.

Also, this class is lacking a unit test, which surely would have picked up this mistake.

Finally, calling a class *Workspace when it's a function is confusing! Could you come up with an alternative name please?

[mantid-builder]

This issue was originally trac ticket 8850

[mantid-builder]

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8850/NormGaussian2.nxs
(uploaded by @VickieLynch on 2014-02-09T21:06:57)

---