Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog insensitive search by name #9782

Closed
mantid-builder opened this issue Feb 7, 2014 · 2 comments
Closed

catalog insensitive search by name #9782

mantid-builder opened this issue Feb 7, 2014 · 2 comments
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done. Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@mantid-builder
Copy link
Collaborator

This issue was originally TRAC 8939

Original Reporter: Jay Rainey

Currently, in the algorithm, UI, and related classes the Investigators name field is refereed to as InvestigatorSurname, which is mis-leading (in fact, it's what the field was previously used as).

If I attempt to search via Investigators name the results returned are not correct, for example, if I search for jay rainey, it does not return any results. However, if I search for Jay Rainey it returns the correct results.

The search for the investigators name therefore needs to be made case insensitive.


Keywords: ICAT

@mantid-builder
Copy link
Collaborator Author

@NickDraper (2014-02-14T10:59:49):
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state


Jay Rainey (2014-04-28T08:26:58):
An [https://code.google.com/p/icatproject/issues/detail?id=133 issue] has been raised regarding usage of LOWER/UPPER. Once ICAT 4.3.3 gets rolled out to ICATDEV (likely some point this week) then this ticket can be addressed.


Jay Rainey (2014-06-09T09:00:53):
Rename investigatorSurName to investigatorName. Refs http://trac.mantidproject.org/mantid/ticket/8939.

e7f7389


Jay Rainey (2014-06-09T09:00:53):
Updated algorithm and interface references to surname. Refs http://trac.mantidproject.org/mantid/ticket/8939.

  • Also updated the error label name for DataFileName.

fe0974b


Jay Rainey (2014-06-09T09:00:54):
Updated references to surname in catalogs. Refs http://trac.mantidproject.org/mantid/ticket/8939.

c7b9b67


Jay Rainey (2014-06-09T09:00:54):
Improved logging messages in CatlogDownloadDataFiles. Refs http://trac.mantidproject.org/mantid/ticket/8939.

0b65f79


Jay Rainey (2014-06-09T09:40:49):
The previous commits above deal with updating the '''surname''' attribute in the ICAT Search algorithm to the more generic '''name'''.

The next part of this ticket ('''which is not yet done''') deals with updating the [https://github.com/mantidproject/mantid/blob/c7b9b679eb1e8de2edc38e53e0379e9653c0c8fe/Code/Mantid/Framework/ICat/src/ICat4/ICat4Catalog.cpp#L201-L208 search query] that is sent to ICAT to be '''lowercase''', e.g. using ''LOWER()''. This ensures that if the user enters '''"Jay"''' or '''"jay"''' into the '''investigators name''' field the query will return the correct results.

As noted in comment:2, there has been an [https://code.google.com/p/icatproject/issues/detail?id=133 issue opened] for the exact cause of this problem. The change has been made and will be introduced to ICAT '''4.3.3'''. Therefore, this ticket cannot be completed until ICAT '''4.3.3''' is released onto the production server. To find out when this will be done you will need to get in contact with Tom Griffin.

When working on this ticket, please use the following branch as it already has the name changes:

  • [https://github.com/mantidproject/mantid/compare/master...feature;8939_icat_insensitive_name_search feature/8939_icat_insensitive_name_search]

@NickDraper (2014-12-08T10:25:32):
Moved to the backlog at the code freeze of R3.3

@mantid-builder mantid-builder added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen added the Low Priority Things that you don't ever want to be done. label Jun 30, 2016
@Anders-Markvardsen
Copy link
Member

may need to be closed

@gemmaguest gemmaguest added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework Low Priority Things that you don't ever want to be done. Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

4 participants