Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change slice2histogram to use FilterEvents #9789

Closed
mantid-builder opened this issue Feb 7, 2014 · 2 comments
Closed

Change slice2histogram to use FilterEvents #9789

mantid-builder opened this issue Feb 7, 2014 · 2 comments
Assignees
Labels
SANS Issues and pull requests related to SANS

Comments

@mantid-builder
Copy link
Collaborator

sans_code
This issue was originally TRAC 8946

Original Reporter: Gesner Passos

Probably, it would be worth using the GenerateEventsFilter as well.

The FilterByTime is to be replaced.

@mantid-builder
Copy link
Collaborator Author

Gesner Passos (2014-02-12T14:10:02):
The change is not straightforward. There are some issues to do this:

GenerateEventFilter would create a Table workspace that would be ok for us to create a single entry or to create many entries. The issue, is that to have the logs splited correctly, it is required to do have the filtered and the unfiltered workspaces. This would greatly impact the performance for a workspace that we will have to delete.

Another possibility is to use these two algorithms as they were designed. Use the GenerateEventFilter to generate all the slices and apply these slices once at all through the FilteEvents.

The issue here is that it requires changing the design of how the reduction is dealing with event workspaces in SANS. The only solution I foreseen is inserting it inside the loader it self. On loading, it would get the definition of the slices and slice all the data. The main issue with this approach is the user interface. Currently, the user interface requires pressing the LOAD button and then the 1D Reduction. And it would require loading and slicing twice for every single reduction.


@NickDraper (2014-03-07T16:20:30):
Ownership handed over to Peter

@mantid-builder mantid-builder added the SANS Issues and pull requests related to SANS label Jun 3, 2015
lottiegreenwood pushed a commit that referenced this issue Nov 26, 2015
lottiegreenwood pushed a commit that referenced this issue Nov 26, 2015
lottiegreenwood pushed a commit that referenced this issue Nov 26, 2015
@AntonPiccardoSelg
Copy link
Contributor

Not very clear what the requirement is. But using FilterByLog is a sensible approach for creating time slices. We are probably as efficient as possible with this in the new backend, since we don't reload. Hence we close the ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SANS Issues and pull requests related to SANS
Projects
None yet
Development

No branches or pull requests

3 participants