Calculate Transmission Polynomial

[mantid-builder]

sans_feature
This issue was originally TRAC 8977

Original Reporter: Gesner Passos

This ticket is blocked by :

• TRAC9030

In calculate transmission, the polynomial order is to be applied to the log of the data, as specified by the scientist:

Are we actually fitting the polynomial to the Log(Trans) ? - Which is what I intended.

[mantid-builder]

Gesner Passos (2014-02-13T15:01:18):
re http://trac.mantidproject.org/mantid/ticket/8977: Make Polynomial of Log(trans) for calculate transmission

1d1acca

---

Gesner Passos (2014-02-13T15:05:54):
While doing this ticket I've spotted an issue with the error propagation http://trac.mantidproject.org/mantid/ticket/9011

---

Gesner Passos (2014-02-13T15:28:28):
Tester:

If rebining is not present, fitting the CalculateTransmission can be reproduced outside as:

• Log(xxx_unfitted)
• Fit
• Exp

The check_calculate_transmission shows how I did this to check the result. The result should be the same except for the error because of the issue presented in http://trac.mantidproject.org/mantid/ticket/9011.

---

Gesner Passos (2014-02-14T09:35:38):
It broke the systemtest LOQReductionGUI.LOQMinimalBatchReduction.

It is ok. That specific test uses as Mask the MaskLOQData.txt which has the following line:

FIT/TRANS/CAN/POLYNOMIAL4 2.2 10.0

Now, we have changed the polynomial to be applied in the Log(trans). Hence, having the results changing is a good signal.

---

Gesner Passos (2014-02-14T10:39:53):
re http://trac.mantidproject.org/mantid/ticket/8977: Update file that uses polynomial fit.

f4bc5d7

---

Gesner Passos (2014-03-05T10:52:49):
http://trac.mantidproject.org/mantid/ticket/9030 will cause the Errors in Fit to change, this will effect CalculateTransmission. Hence, before applying this ticket, specially because it changes Systemtest data, it is better to wait for http://trac.mantidproject.org/mantid/ticket/9030.

---

Gesner Passos (2014-03-05T10:57:35):
Tester:

You can use check8977.py to check this ticket as well, it is a variation of the one proposed in http://trac.mantidproject.org/mantid/ticket/9011 to allow checking for the Polynomial fit.

---

Gesner Passos (2014-03-05T11:10:29):
Peter:

Because http://trac.mantidproject.org/mantid/ticket/9030 is delayed (waiting for the green signal from Martyn), I won't be able to push this one. comment:2 is the commit that implements what is required in this ticket. You will probably need to run again the systemtest that produced the comment:9 because it was done before the addition of http://trac.mantidproject.org/mantid/ticket/9030.

As soon as this pass, please inform Richard who is keen to test this new feature.

---

Gesner Passos (2014-03-05T11:16:06):
The check8977_real_example.py allows you to check against a real use-case proposed from the user.

---

Gesner Passos (2014-03-05T11:18:30):
What we do not want as answer. But it depends on http://trac.mantidproject.org/mantid/ticket/9030.

---

@PeterParker (2014-06-19T08:56:30):
I have yet to look into this, but it seems that Gesner had possibly completed this but was just waiting for another ticket to clear. I will take a look after the release.

---

@NickDraper (2014-12-08T10:25:32):
Moved to the backlog at the code freeze of R3.3

---

@PeterParker (2015-03-15T18:25:36):
Merge branch 'master' into feature/8977_calculate_transmission_poly

Conflicts:
Code/Mantid/Framework/Algorithms/src/CalculateTransmission.cpp

Refs http://trac.mantidproject.org/mantid/ticket/8977

3ccb3b0

[mantid-builder]

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8977/check_calculate_transmission.py
(uploaded by Gesner Passos on 2014-02-13T15:22:56)

---

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8977/check8977.py
(uploaded by Gesner Passos on 2014-03-05T10:54:03)

---

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8977/check8977_real_example.py
(uploaded by Gesner Passos on 2014-03-05T11:10:40)

---

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8977/21005_trans_several_errors.pdf
(uploaded by Gesner Passos on 2014-03-05T11:18:30)

---

[Matthew-Andrew]

As far as I can tell the commit referenced here was never actually merged and polynomial fit still currently fits the raw data. Having talked to the instrument scientists polynomial fit will now have to continue to do so as this is now an established use but an extra option Log polynomial fit could be added.

[smk78]

Having reviewed this issue the SANS Group believe it is obsolete so I am closing this issue. (If we change our minds it can always be reopened...!)