Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck errors in InstrumentWindow code #9840

Closed
martyngigg opened this issue Feb 12, 2014 · 1 comment
Closed

cppcheck errors in InstrumentWindow code #9840

martyngigg opened this issue Feb 12, 2014 · 1 comment
Assignees
@mantid-roman
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 3.2

Comments

@martyngigg
Copy link
Member

There are several cppcheck warnings in the instrument view code. See one of the latest jobs [http://download.mantidproject.org/jenkins/view/Static%20Analysis/job/is_cppcheck_develop/ here]

cppcheck is confused by the macro usage in GLActorVisitor & InstrumentActor. We discussed refactoring the code improve the readability and just use virtual functions that have a default implementation to avoid these issues.

It would be good to get this done in the maintenace period so that we can drive the cppcheck errors to zero.

Keywords: Maintenance
@martyngigg
Copy link
Member Author

This issue was originally trac ticket 8997

@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. GUI Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@martyngigg martyngigg added this to the Release 3.2 milestone Jun 3, 2015
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Refs #9840 Fix typo in previous commit
da0c61c
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Merge branch 'master' into feature/9840_reflectometryreductionone_pol…
8f25e48 
…arizationcorrection

Refs #9840

This merge is to incorporate the changes from #10524 into #9840.
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Refs #9840 Remove polref duct tape from ReflMainViewPresenter
6669f2f
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Refs #9840 Implement polarization correction
3e21069 
Known bug: History is not recorded correctly.
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Refs #9840 Don't use the ADS in ReflectometryReductionOneAuto
1233ec6
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Revert "Refs #9840 Don't use the ADS in ReflectometryReductionOneAuto"
c7e784e 
This reverts commit 1233ec6.
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Refs #9840 Tidy up execution order
2d5ed6a 
We can group the IvsQ workspaces at the same time as the IvsLam ones
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Refs #9840 Fix error when re-stitching polref results
4daab45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantid-roman mantid-roman

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
2 participants
@martyngigg @mantid-roman