Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Units on ConvertMDHistoToMatrixWorkspace #9852

Closed
OwenArnold opened this issue Feb 13, 2014 · 1 comment
Closed

Fix Units on ConvertMDHistoToMatrixWorkspace #9852

OwenArnold opened this issue Feb 13, 2014 · 1 comment
Assignees
Labels
Diffraction Issues and pull requests related to diffraction High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@OwenArnold
Copy link
Contributor

This ticket is blocks : TRAC8992

The following illustrates the problem.

#!python
CreateMDWorkspace(Dimensions='2',EventType='MDEvent',Extents='-10,10,-10,10',Names='Q_lab_x,Q_lab_y',Units='A,B',OutputWorkspace='test')
FakeMDEventData(InputWorkspace='test',UniformParams='1000',PeakParams='100000,0,0,1')
# Create a line cut
line_md = BinMD(InputWorkspace='test',AxisAligned='0',BasisVector0='X,units,0.888154,0.459545',BasisVector1='Y,units,-0.459545,0.888154',Translation='-4.93562,-2.3918',OutputExtents='0,9.61632,-0.1,0.1',OutputBins='100,1')
line_2d = ConvertMDHistoToMatrixWorkspace(line_md)
plotMD(line_md)
plotSpectrum(line_2d, 0)

These plots should be equivalent, but the X-units are wrong in the line_2d cut. This is because the Convert algorithm isn't properly sourcing the coordinate transformations. The default should be that it does. An optional parameter expressing the need to preserve the existing behaviour would be desirable.


Keywords: PatchCandidate

@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 9009

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Diffraction Issues and pull requests related to diffraction labels Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.1.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant