Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when multiple IDF for instrument #9897

Closed
Anders-Markvardsen opened this issue Feb 20, 2014 · 1 comment
Closed

Improve performance when multiple IDF for instrument #9897

Anders-Markvardsen opened this issue Feb 20, 2014 · 1 comment
Assignees
Labels
Framework Issues and pull requests related to components in the Framework

Comments

@Anders-Markvardsen
Copy link
Member

This issue was originally TRAC 9054

This is based on the observation from http://trac.mantidproject.org/mantid/ticket/8844 where it was observed that adding an additional SANS2D IDF caused a noticeable increase for the SANS2D systemtests.

Specifically it was observed from https://builds.sns.gov/view/Tests/job/ornl_test_rhel6_develop/System_tests_performance/ that the systemtest SystemTests.SANS2DFrontNoGrav.SANS2DFrontNoGrav saw a noticeable increase at revision 811 (when 2nd SAND2D IDF was added) and exactly the same drop when removed at revision 859. The is also observed for the other SANS2D systemtests, e.g. SystemTests.SANS2DBatch.SANS2DBatch.

The increase in performance is about 3 seconds, this about matches the increase of SystemTests.LoadLotsOfInstruments.LoadLotsOfInstruments and indicates that the entire IDF may be loaded during the process of Mantid deciding which IDF to load.

It is noted that all the SANS2D systemtests would have failed had the new SANS2D IDF been used rather than the old SANS2D IDF, hence the correct select of IDF is made by Mantid.

It should be possible to improve the Mantid code such that it takes less than 3 seconds to decide which of the two SANS2D IDFs to load.

Without looking in detail at the code the recollection is that we are using the SAX parser for investigating IDF dates, however this code may never have been checked for performance.

The purpose of this ticket is to improve the performance of the SANS2D systemtests, which is also expected to cause a performance gain for other instruments.

@Anders-Markvardsen Anders-Markvardsen added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@Anders-Markvardsen Anders-Markvardsen self-assigned this Jun 3, 2015
@Anders-Markvardsen
Copy link
Member Author

Other ISIS work has superseeded this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant