Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDS catalog interface #9912

Closed
mantid-builder opened this issue Feb 21, 2014 · 2 comments
Closed

IDS catalog interface #9912

mantid-builder opened this issue Feb 21, 2014 · 2 comments
Labels
Framework Issues and pull requests related to components in the Framework
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Jay Rainey

This ticket is blocks : TRAC7640, TRAC9026

The methods getDownloadURL and getUploadURL in ICatalog need to be re-factored into their own interface as it's not possible to call them within a compositeCatalog (http://trac.mantidproject.org/mantid/ticket/9026). They are part of the Information Data Service (IDS), which is a separate API from ICAT. (Though, it uses investigationIds etc that are obtained via ICAT)

To resolve this issue I need to:

  1. Create a new interface (CatalogInfoService) that contains the two method signatures.
  2. Inherit this interface in ICat4Catalog. (I should not have to change much within this class)
  3. Remove the related methods from ICat3Catalog as it does not have an IDS.
  4. Remove keepAliveinminutes method from ICatalog as it's not used, and will not function as expected in the compositeCatalog. The keepAlive method is more than sufficient.

'''Note:''' the catalog algorithms that use these methods should not be affected as they call the catalog in use. Better exception handling should be put in place to ensure if a catalog is used that does not support an IDS then the user will know. The algorithms are:

  • CatalogDownloadDataFiles(uses getDownloadURL)

  • CatalogDownloadDataSets (uses getDownloadURL)

  • CatalogPublish (uses getUploadURL)

    Keywords: ICAT,IDS

@mantid-builder mantid-builder added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 9069

@mantid-builder
Copy link
Collaborator Author

http://trac.mantidproject.org/mantid/raw-attachment/ticket/9069/ICatBefore.jpg
ICatBefore.jpg
(uploaded by Jay Rainey on 2014-02-24T09:44:05)


http://trac.mantidproject.org/mantid/raw-attachment/ticket/9069/ICatAfter.jpg
ICatAfter.jpg
(uploaded by Jay Rainey on 2014-02-24T09:44:14)


@mantid-builder mantid-builder added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant