You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The methods getDownloadURL and getUploadURL in ICatalog need to be re-factored into their own interface as it's not possible to call them within a compositeCatalog (http://trac.mantidproject.org/mantid/ticket/9026). They are part of the Information Data Service (IDS), which is a separate API from ICAT. (Though, it uses investigationIds etc that are obtained via ICAT)
To resolve this issue I need to:
Create a new interface (CatalogInfoService) that contains the two method signatures.
Inherit this interface in ICat4Catalog. (I should not have to change much within this class)
Remove the related methods from ICat3Catalog as it does not have an IDS.
Remove keepAliveinminutes method from ICatalog as it's not used, and will not function as expected in the compositeCatalog. The keepAlive method is more than sufficient.
'''Note:''' the catalog algorithms that use these methods should not be affected as they call the catalog in use. Better exception handling should be put in place to ensure if a catalog is used that does not support an IDS then the user will know. The algorithms are:
CatalogDownloadDataFiles(uses getDownloadURL)
CatalogDownloadDataSets (uses getDownloadURL)
CatalogPublish (uses getUploadURL)
Keywords: ICAT,IDS
The text was updated successfully, but these errors were encountered:
Original Reporter: Jay Rainey
This ticket is blocks :
TRAC7640,TRAC9026The methods
getDownloadURL
andgetUploadURL
inICatalog
need to be re-factored into their own interface as it's not possible to call them within acompositeCatalog
(http://trac.mantidproject.org/mantid/ticket/9026). They are part of the Information Data Service (IDS), which is a separate API from ICAT. (Though, it uses investigationIds etc that are obtained via ICAT)To resolve this issue I need to:
CatalogInfoService
) that contains the two method signatures.ICat4Catalog
. (I should not have to change much within this class)ICat3Catalog
as it does not have an IDS.keepAliveinminutes
method fromICatalog
as it's not used, and will not function as expected in thecompositeCatalog
. ThekeepAlive
method is more than sufficient.'''Note:''' the catalog algorithms that use these methods should not be affected as they call the catalog in use. Better exception handling should be put in place to ensure if a catalog is used that does not support an IDS then the user will know. The algorithms are:
CatalogDownloadDataFiles
(usesgetDownloadURL
)CatalogDownloadDataSets
(usesgetDownloadURL
)CatalogPublish
(usesgetUploadURL
)Keywords: ICAT,IDS
The text was updated successfully, but these errors were encountered: