Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflectometry 3.1.1 issue to investigate - Possible defect #9952

Closed
OwenArnold opened this issue Mar 3, 2014 · 1 comment
Closed

Reflectometry 3.1.1 issue to investigate - Possible defect #9952

OwenArnold opened this issue Mar 3, 2014 · 1 comment
Assignees
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@OwenArnold
Copy link
Contributor

See below. This is probably due to changes made to Stitch1D. I'm confident that changes made to Stitch1D and Stitch1DMany were for the better, but it could be due to auxiliary workspaces not sitting around in the ADS. Needs investigation in any case.

Hi Owen,

3.1.1 seems to have broken a previously working script on the line

DataOut=CloneWorkspace(GroupWorkspaces([nIp, nIa]))

The error dump is included below.  

This is part of the polarization corrections that I coded to test ReflectometryReductionOneAuto and may be obsolete by now.  Do you have a replacement/ workaround/ fix? 

Many thanks,  
Tim
------------------------------------------------------------------------ - - - 
RuntimeError                              Traceback (most recent call last)
`<ipython-input-2-f611aa3039dc>` in `<module>`()
      4 
      5 from mantid.simpleapi import *
----> 6 from WrappedReduction import *

u:\user\mantid\TestingPointDetectorReduction\WrappedReduction.py in `<module>`()
    353 
    354 #####################        M2-0167 T=5K
--> 355 ( _ ,r1q , _)= ref('8169+8171+8173+8175+8177+8179+8181',theta=0.4)
    356 
    357 print r1q

u:\user\mantid\TestingPointDetectorReduction\WrappedReduction.py in ref(RunNumbers, theta)
    325         trans=CorrectMonitor(trans)
    326         (_,rl,ThetaOut)=ReflectometryReductionOneAuto(InputWorkspace=dd,I0MonitorIndex='2',ProcessingInstructions='3',ThetaIn=theta,FirstTransmissionRun=trans,StrictSpectrumChecking=False)
--> 327         RcorrectedVsLambda = CorrectPolarization(rl)
    328         RcorrectedVsQz = RcorrectedVsLambda.convertUnits('MomentumTransfer')
    329         return RcorrectedVsQz, RcorrectedVsLambda, ThetaOut

u:\user\mantid\TestingPointDetectorReduction\WrappedReduction.py in CorrectPolarization(TheDataIn)
    281                 nIa = ( Ip * (rho * Pp - 1.0) + Ia * (Pp + 1.0) ) / D
    282                 #print "nIp,nIa ",nIp, nIa
--> 283                 DataOut=CloneWorkspace(GroupWorkspaces([nIp, nIa]))
    284                 return DataOut
    285 

C:\MantidInstall\bin\mantid\simpleapi.pyc in algorithm_wrapper(*InputWorkspaces, **Version=1)
    565 
    566         _set_properties(algm, *args, **final_keywords)
--> 567         algm.execute()
    568         return _gather_returns(algorithm, lhs, algm)
    569 

RuntimeError: Some invalid Properties found
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 9109

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold OwenArnold self-assigned this Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.2 milestone Jun 3, 2015
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
We can't plot a matrix if it's not been loaded yet.
KarlPalmen pushed a commit that referenced this issue Nov 26, 2015
Since v3.2 and prior crash when dealing with spectrograms, we don't have
to worry about compatibility, so we're allowed to deal with this a
little more simply.

If the spectrogram's based off a matrix, we specify the matrix by its
name. If the spectrogram's based off a workspace, we specify the
workspace by its name.

Load and save accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

1 participant