Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PropertyWidgets in Custom Dialogs #9992

Closed
1 task done
PeterParker opened this issue Mar 9, 2014 · 3 comments
Closed
1 task done

Use PropertyWidgets in Custom Dialogs #9992

PeterParker opened this issue Mar 9, 2014 · 3 comments
Assignees
Labels
Stale This label is automatically applied to issues that are automatically closed by the stale bot

Comments

@PeterParker
Copy link
Contributor

This issue was originally TRAC 9149

This ticket is blocked by :

The dynamically-generated algorithm dialogs use PropertyWidget objects. The customised algorithm dialogs (and perhaps others) should be made to use them too. This will make things more consistent, both visually and within the code, it will avoid code duplication, and will also allow make the http://trac.mantidproject.org/mantid/ticket/2480 functionality more widespread.

''No work required'':

  • SmoothNeighbours - (Already uses PropertyWidgets fully)
  • LoadDAE - (Deleted algorithm)
  • LOQScriptInput - (Deleted algorithm)

''Work required'':

  • CatalogPublish
  • ConvertTableToMatrixWorkspace
  • CreateSampleShape
  • Fit
  • LoadAscii
  • Load
  • LoadInstrument
  • LoadRaw
  • PlotAsymmetryByLogValue
  • BinMD - (SlicingAlgorithmDialog)
  • SliceMD - (SlicingAlgorithmDialog)
  • StartLiveData
@PeterParker
Copy link
Contributor Author

@NickDraper (2014-06-23T08:01:10):
Moved to Backlog at the code freeze of release 3.2


@PeterParker (2015-03-15T18:25:09):
Refs http://trac.mantidproject.org/mantid/ticket/9149 - Remove CustomDialog for CatalogPublish algorithm.

Instead use IPropertySetting objects to handle property complexities.

Eagle-eyed code reviewers will note that these changes don't work very
well with composite catalogs, but neither did the custom algorithm dialog
in its previous form. This will need to be revisited when composite
catalogs are finished. In particular, what should be the allowed values
of the InvestigationNumber property given multiple session IDs? How
should the allowed values (as well as the default value) of the SessionID
property change as well?

Also, for now, "FileName" and "InputWorkspace" are back to being on two
separate rows in the dialog.

1ea0c96


@PeterParker (2015-03-15T18:25:09):
Refs http://trac.mantidproject.org/mantid/ticket/9149 - WIP. Needs rebasing.

c090365

@PeterParker PeterParker added the GUI label Jun 3, 2015
@PeterParker PeterParker self-assigned this Jun 3, 2015
@stale
Copy link

stale bot commented Feb 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you feel this is incorrect please comment to keep it alive, with a reason why.

To prevent closure, e.g. for long-term planning issues, add the "Never Stale" label.

@stale stale bot added the Stale This label is automatically applied to issues that are automatically closed by the stale bot label Feb 24, 2021
@stale
Copy link

stale bot commented Mar 3, 2021

This issue has been closed automatically. If this still affects you please re-open this issue with a comment so we can look into resolving it.

@stale stale bot closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale This label is automatically applied to issues that are automatically closed by the stale bot
Projects
None yet
Development

No branches or pull requests

1 participant