Skip to content

Commit

Permalink
Added events dealing with creation and updates to versions.
Browse files Browse the repository at this point in the history
  • Loading branch information
amyreese committed Apr 4, 2009
1 parent 3b837f1 commit 3e0c10d
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 4 deletions.
3 changes: 3 additions & 0 deletions core/events_inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@
'EVENT_MANAGE_PROJECT_UPDATE_FORM' => EVENT_TYPE_EXECUTE,
'EVENT_MANAGE_PROJECT_UPDATE' => EVENT_TYPE_EXECUTE,
'EVENT_MANAGE_PROJECT_PAGE' => EVENT_TYPE_EXECUTE,
'EVENT_MANAGE_VERSION_CREATE' => EVENT_TYPE_EXECUTE,
'EVENT_MANAGE_VERSION_UPDATE_FORM' => EVENT_TYPE_EXECUTE,
'EVENT_MANAGE_VERSION_UPDATE' => EVENT_TYPE_EXECUTE,

# User account pages
'EVENT_ACCOUNT_PREF_UPDATE_FORM' => EVENT_TYPE_EXECUTE,
Expand Down
2 changes: 1 addition & 1 deletion core/version_api.php
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ function version_add( $p_project_id, $p_version, $p_released = VERSION_FUTURE, $
db_query_bound( $query, Array( $c_project_id, $p_version, $c_date_order, $p_description, $c_released, $c_obsolete ) );

# db_query errors on failure so:
return true;
return db_insert_id( $t_project_version_table );
}

# --------------------
Expand Down
4 changes: 2 additions & 2 deletions manage_proj_ver_add.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@

$t_version = trim( $t_version );
if ( version_is_unique( $t_version, $f_project_id ) ) {
version_add( $f_project_id, $t_version );
$t_version_id = version_add( $f_project_id, $t_version );
event_signal( 'EVENT_MANAGE_VERSION_CREATE', array( $t_version_id ) );
} else if ( 1 == $t_version_count ) {
# We only error out on duplicates when a single value was
# given. If multiple values were given, we just add the
Expand All @@ -72,7 +73,6 @@
form_security_purge( 'manage_proj_ver_add' );

if ( true == $f_add_and_edit ) {
$t_version_id = version_get_id( $t_version, $f_project_id );
$t_redirect_url = 'manage_proj_ver_edit_page.php?version_id='.$t_version_id;
} else {
$t_redirect_url = 'manage_proj_edit_page.php?project_id=' .$f_project_id;
Expand Down
3 changes: 2 additions & 1 deletion manage_proj_ver_copy.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@

foreach ( $t_rows as $t_row ) {
if ( version_is_unique( $t_row['version'], $t_dst_project_id ) ) {
version_add( $t_dst_project_id, $t_row['version'], $t_row['released'], $t_row['description'], db_date( $t_row['date_order'] ) );
$t_version_id = version_add( $t_dst_project_id, $t_row['version'], $t_row['released'], $t_row['description'], db_date( $t_row['date_order'] ) );
event_signal( 'EVENT_MANAGE_VERSION_CREATE', array( $t_version_id ) );
}
}

Expand Down
1 change: 1 addition & 0 deletions manage_proj_ver_edit_page.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
<input type="checkbox" name="obsolete" <?php check_checked( $t_version->obsolete, true ); ?> />
</td>
</tr>
<?php event_signal( 'EVENT_MANAGE_VERSION_UPDATE_FORM', array( $t_version->id ) ); ?>
<tr>
<td>
&nbsp;
Expand Down
1 change: 1 addition & 0 deletions manage_proj_ver_update.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
$t_version->date_order = $f_date_order;

version_update( $t_version );
event_signal( 'EVENT_MANAGE_VERSION_UPDATE_FORM', array( $t_version->id ) );

form_security_purge( 'manage_proj_ver_update' );

Expand Down

0 comments on commit 3e0c10d

Please sign in to comment.