Skip to content

Commit

Permalink
HTML/CSS fixes for summary page
Browse files Browse the repository at this point in the history
  • Loading branch information
@dregad
dregad committed May 20, 2014
1 parent ca777bb commit 74fa649
Show file tree
Hide file tree
Showing 3 changed files with 232 additions and 236 deletions.
22 changes: 11 additions & 11 deletions core/summary_api.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ function summary_print_by_date( $p_date_array ) {
}

/**
* Print list of open bugs with the highest activity score the score is calculated assigning
* Print list of open bugs with the highest activity score the score is calculated assigning
* one "point" for each history event associated with the bug
*/
function summary_print_by_activity() {
Expand Down Expand Up @@ -890,7 +890,7 @@ function summary_print_developer_resolution( $p_resolution_enum_string ) {
$t_row_count++;
echo '<td>';
echo summary_helper_get_developer_label( $t_handler_id );
echo '</td>';
echo "</td>\n";

# We need to track the percentage of bugs that are considered fixed, as well as
# those that aren't considered bugs to begin with (when looking at %age)
Expand All @@ -903,15 +903,15 @@ function summary_print_developer_resolution( $p_resolution_enum_string ) {
$res_bug_count = $t_arr2[$c_res_s[$j]];
}

echo '<td>';
echo '<td class="right">';
if( 0 < $res_bug_count ) {
$t_bug_link = '<a class="subtle" href="' . $t_filter_prefix . '&amp;' . FILTER_PROPERTY_HANDLER_ID . '=' . $t_handler_id;
$t_bug_link = $t_bug_link . '&amp;' . FILTER_PROPERTY_RESOLUTION . '=' . $c_res_s[$j] . '">';
echo $t_bug_link . $res_bug_count . '</a>';
} else {
echo $res_bug_count;
}
echo '</td>';
echo "</td>\n";

if( $c_res_s[$j] >= config_get( 'bug_resolution_fixed_threshold' ) ) {
if ( $c_res_s[$j] < config_get( 'bug_resolution_not_fixed_threshold' ) ) {
Expand All @@ -929,9 +929,9 @@ function summary_print_developer_resolution( $p_resolution_enum_string ) {
if(( $t_arr2['total'] - $t_bugs_notbugs ) > 0 ) {
$t_percent_fixed = ( $t_bugs_fixed / ( $t_arr2['total'] - $t_bugs_notbugs ) );
}
echo '<td>';
echo '<td class="right">';
printf( '% 1.0f%%', ( $t_percent_fixed * 100 ) );
echo '</td>';
echo "</td>\n";
echo '</tr>';
}
}
Expand Down Expand Up @@ -1005,7 +1005,7 @@ function summary_print_reporter_resolution( $p_resolution_enum_string ) {
$t_row_count++;
echo '<td>';
echo string_display_line( user_get_name( $t_reporter_id ) );
echo '</td>';
echo "</td>\n";

# We need to track the percentage of bugs that are considered fix, as well as
# those that aren't considered bugs to begin with (when looking at %age)
Expand All @@ -1018,15 +1018,15 @@ function summary_print_reporter_resolution( $p_resolution_enum_string ) {
$res_bug_count = $t_arr2[$c_res_s[$j]];
}

echo '<td>';
echo '<td class="right">';
if( 0 < $res_bug_count ) {
$t_bug_link = '<a class="subtle" href="' . config_get( 'bug_count_hyperlink_prefix' ) . '&amp;' . FILTER_PROPERTY_REPORTER_ID . '=' . $t_reporter_id;
$t_bug_link = $t_bug_link . '&amp;' . FILTER_PROPERTY_RESOLUTION . '=' . $c_res_s[$j] . '">';
echo $t_bug_link . $res_bug_count . '</a>';
} else {
echo $res_bug_count;
}
echo '</td>';
echo "</td>\n";

if( $c_res_s[$j] >= config_get( 'bug_resolution_fixed_threshold' ) ) {
if ( $c_res_s[$j] < config_get( 'bug_resolution_not_fixed_threshold' ) ) {
Expand All @@ -1044,9 +1044,9 @@ function summary_print_reporter_resolution( $p_resolution_enum_string ) {
if( $t_total_user_bugs > 0 ) {
$t_percent_errors = ( $t_bugs_notbugs / $t_total_user_bugs );
}
echo '<td>';
echo '<td class="right">';
printf( '% 1.0f%%', ( $t_percent_errors * 100 ) );
echo '</td>';
echo "</td>\n";
echo '</tr>';
}
}
Expand Down
20 changes: 20 additions & 0 deletions css/default.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ fieldset > .field-container:nth-child(odd),
form > table > tr:nth-child(odd),
div.table-container > table > tbody > tr:nth-child(odd),
div.table-container > table > tr:nth-child(odd),
div.summary-container > table > tbody > tr:nth-child(odd),
div.form-container > form > table > tbody > tr:nth-child(odd),
div.form-container > form > fieldset > table > tbody > tr:nth-child(odd),
div.form-container > table > tbody > tr:nth-child(odd),
Expand All @@ -557,6 +558,7 @@ form > table > tr:nth-child(even),
table#manage-overview-table > tr:nth-child(even),
div.table-container > table > tbody > tr:nth-child(even),
div.table-container > table > tr:nth-child(even),
div.summary-container > table > tbody > tr:nth-child(even),
div.form-container > form > table > tbody > tr:nth-child(even),
div.form-container > form > fieldset > table > tbody > tr:nth-child(even),
div.form-container > table > tbody > tr:nth-child(even),
Expand Down Expand Up @@ -718,3 +720,21 @@ span.dependency_dated { color: maroon; }
span.dependency_met { color: green; }
span.dependency_unmet { color: red; }
span.dependency_upgrade { color: orange; }

/* summary page */
div.summary-container {
position: relative;
padding: 1px;
width: 49.5%;
}
div.summary-container table {
width: 100%;
border-spacing: 1px;
border: solid 1px #000000;
position: relative;
margin-bottom: 10px;
}
div#summary { width: 100%; padding: 0 4px;}
div#summary-left { float: left; }
div#summary-right { float: right; }
div#summary-bottom { width: 99.8%; clear: both; }
Loading

0 comments on commit 74fa649

Please sign in to comment.