Skip to content

Commit

Permalink
Add <label> to form inputs
Browse files Browse the repository at this point in the history
To comply with WCAG standard, inputs should be associated with a label.

This requires a CSS tweak CSS to ensure consistent display of labels in
bold font.

Fixes #27258
  • Loading branch information
dregad committed Sep 18, 2020
1 parent 53d584d commit d27ea37
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
16 changes: 12 additions & 4 deletions account_prof_menu_page.php
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,9 @@
<tr>
<td class="category">
<span class="required">*</span>
<?php echo lang_get( 'platform' ) ?>
<label for="platform">
<?php echo lang_get( 'platform' ) ?>
</label>
</td>
<td>
<input type="text" class="input-sm"
Expand All @@ -267,7 +269,9 @@
<tr>
<td class="category">
<span class="required">*</span>
<?php echo lang_get( 'os' ) ?>
<label for="os">
<?php echo lang_get( 'os' ) ?>
</label>
</td>
<td>
<input type="text" class="input-sm"
Expand All @@ -278,7 +282,9 @@
<tr>
<td class="category">
<span class="required">*</span>
<?php echo lang_get( 'os_build' ) ?>
<label for="os_build">
<?php echo lang_get( 'os_build' ) ?>
</label>
</td>
<td>
<input type="text" class="input-sm"
Expand All @@ -288,7 +294,9 @@
</tr>
<tr>
<td class="category">
<?php echo lang_get( 'additional_description' ) ?>
<label for="description">
<?php echo lang_get( 'additional_description' ) ?>
</label>
</td>
<td>
<textarea id="description" name="description"
Expand Down
5 changes: 5 additions & 0 deletions css/ace-mantis.css
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ textarea.input-xs, select.input-xs[multiple] {
padding: 1px 3px;
}

th > label,
td > label {
font-weight: bold;
}

.scrollable-menu {
height: auto;
max-height: 435px;
Expand Down

0 comments on commit d27ea37

Please sign in to comment.