Strip null bytes out of GPC input strings

mantis · mantis · commit fc02c46eea9d · 2013-10-12T22:58:43.000+01:00
diff --git a/core/gpc_api.php b/core/gpc_api.php
@@ -111,7 +111,7 @@ function gpc_get_string( $p_var_name, $p_default = null ) {
 		trigger_error( ERROR_GPC_ARRAY_UNEXPECTED, ERROR );
 	}
 
-	return $t_result;
+	return str_replace( "\0","",$t_result );
 }
 
 /**
@@ -256,7 +256,11 @@ function gpc_get_string_array( $p_var_name, $p_default = null ) {
 		trigger_error( ERROR_GPC_ARRAY_EXPECTED, ERROR );
 	}
 
-	return $t_result;
+	$t_array = array();
+	foreach( $t_result as $key => $val ) {
+		$t_array[$key] = str_replace( "\0", "", $val );
+	}
+	return $t_array;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ function gpc_get_string( $p_var_name, $p_default = null ) {`
`111`	`111`	`trigger_error( ERROR_GPC_ARRAY_UNEXPECTED, ERROR );`
`112`	`112`	`}`
`113`	`113`
`114`		`- return $t_result;`
	`114`	`+ return str_replace( "\0","",$t_result );`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`/**`
`@@ -256,7 +256,11 @@ function gpc_get_string_array( $p_var_name, $p_default = null ) {`
`256`	`256`	`trigger_error( ERROR_GPC_ARRAY_EXPECTED, ERROR );`
`257`	`257`	`}`
`258`	`258`
`259`		`- return $t_result;`
	`259`	`+ $t_array = array();`
	`260`	`+ foreach( $t_result as $key => $val ) {`
	`261`	`+ $t_array[$key] = str_replace( "\0", "", $val );`
	`262`	`+ }`
	`263`	`+ return $t_array;`
`260`	`264`	`}`
`261`	`265`
`262`	`266`	`/**`